Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack to fix runtime deps erroring #52

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Hack to fix runtime deps erroring #52

merged 2 commits into from
Apr 7, 2024

Conversation

NotNite
Copy link
Contributor

@NotNite NotNite commented Dec 31, 2023 •
edited
Loading

  • Added runtimes we were having issues with to the RUNTIME_PACKAGES constant (OBSPlugin and SonarPlugin)
  • Made runtime deps a warning instead of fatal because some of them just don't exist I guess. Not too happy about this so I'd like some input
  • Removed the assumption that [..6] was safe and instead splits the string - I tested this on both plugins with issues and it seems to work okay? Hope that's enough
  • This does not update the extended image because I have no idea how to do that

@karashiiro
Copy link
Contributor

Would be really cool to get this merged, I just spent 3 hours working around mostly this issue goatcorp/DalamudPluginsD17#3348

@philpax
Copy link
Contributor

philpax commented Mar 24, 2024

@goaaats any reason not to merge this?

@goaaats goaaats merged commit f55c4f7 into goatcorp:master Apr 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goaaats goaaats goaaats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NotNite @karashiiro @philpax @goaaats