Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dalamud.RichPresence 2.0.6.5 #5382

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Dalamud.RichPresence 2.0.6.5 #5382

merged 2 commits into from
Jan 25, 2025

Conversation

reiichi001
Copy link
Contributor

@reiichi001 reiichi001 commented Jan 24, 2025 •
edited
Loading

nofranz

@bleatbot bleatbot enabled auto-merge (squash) January 24, 2025 08:01
@bleatbot
Copy link
Collaborator

bleatbot commented Jan 24, 2025 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 5 hours.

Name Commit Status
✔️ Dalamud.RichPresence [stable] c234057 v2.0.6.5 - Diff (15 lines, prev. 2.0.6.4) - Semantic
14 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet DiscordRichPresence 1.2.1.24 philpax
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
NuGet Microsoft.NETCore.Platforms 2.0.0 philpax
NuGet Microsoft.Win32.Registry 4.5.0 philpax
NuGet System.Security.AccessControl 4.5.0 philpax
NuGet System.Security.Principal.Windows 4.5.0 philpax
8 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added the size-small Diff for this PR is small. label Jan 24, 2025
@reiichi001
enable assets again
1ef8705 
Discord fixed it before this was merged. ...we can still provide the RPC Bridge update though.
@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ Dalamud.RichPresence [stable] 13b153c v2.0.6.5 - Diff (4 lines, prev. 2.0.6.4) - Semantic
14 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet DiscordRichPresence 1.2.1.24 philpax
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
NuGet Microsoft.NETCore.Platforms 2.0.0 philpax
NuGet Microsoft.Win32.Registry 4.5.0 philpax
NuGet System.Security.AccessControl 4.5.0 philpax
NuGet System.Security.Principal.Windows 4.5.0 philpax
8 hidden needs (known safe NuGet packages).
Show log - Review

philpax
philpax approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@philpax philpax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably have some kind of policy around binaries

@bleatbot bleatbot merged commit 744b514 into goatcorp:main Jan 25, 2025
2 checks passed
@reiichi001
Copy link
Contributor Author

iirc, Blooym tried to have it pulled programmatically, but it wasn't working reliably. Alternatively, we could/should package the Wine bridge with xlcore (this how XOM handles this dependency for macOS users). Then other plugins could make use of it too.

Felscream pushed a commit to Felscream/DragoonMayCryD17 that referenced this pull request Feb 2, 2025
@reiichi001 @Felscream
Dalamud.RichPresence 2.0.6.5 (goatcorp#5382)
b28340a 
* Dalamud.RichPresence 2.0.6.5

* enable assets again

Discord fixed it before this was merged. ...we can still provide the RPC Bridge update though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philpax philpax philpax approved these changes

Assignees
No one assigned
Labels
size-small Diff for this PR is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reiichi001 @bleatbot @philpax