Change the way the build arguments are being parsed in the github flo…

…ws to make sure they dont get seen as 1 argument
goalgorilla · Feb 13, 2024 · d858a50 · d858a50
1 parent f949c12
commit d858a50
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/build-solr.yml b/.github/workflows/build-solr.yml
@@ -51,7 +51,9 @@ jobs:
         id: docker_build
         uses: docker/build-push-action@v4
         with:
-          build-args: VERSION=${{ matrix.version }} CONFIG_VERSION=${{ matrix.config_version }}
+          build-args: |
+              "VERSION=${{ matrix.version }}"
+              "CONFIG_VERSION=${{ matrix.config_version }}"
           context: "{{defaultContext}}:${{ env.SUBDIRECTORY }}"
           push: true
           tags: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ matrix.version }}

diff --git a/.github/workflows/build-tugboat-solr.yml b/.github/workflows/build-tugboat-solr.yml
@@ -51,7 +51,9 @@ jobs:
         id: docker_build
         uses: docker/build-push-action@v4
         with:
-          build-args: VERSION=${{ matrix.version }} CONFIG_VERSION=${{ matrix.config_version }}
+          build-args: |
+              "VERSION=${{ matrix.version }}"
+              "CONFIG_VERSION=${{ matrix.config_version }}"
           context: "{{defaultContext}}:${{ env.SUBDIRECTORY }}"
           push: true
           tags: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ matrix.version }}

diff --git a/solr/Dockerfile b/solr/Dockerfile
@@ -1,4 +1,5 @@
 ARG VERSION=latest
+ARG CONFIG_VERSION=9
 
 FROM solr:$VERSION
 

diff --git a/tugboat-solr/Dockerfile b/tugboat-solr/Dockerfile
@@ -1,4 +1,5 @@
 ARG VERSION=latest
+ARG CONFIG_VERSION=9
 
 FROM tugboatqa/solr:$VERSION