-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PD online status #135
Conversation
Fixes: #133 |
PD mode always returns online state for PD because PD does not have any state. But some users pefer to use the last poll time stamp as an indicator for PD online/offline status. Let us fix the code to do just that. Fixes: #133 Signed-off-by: Siddharth Chandrasekaran <[email protected]>
Signed-off-by: Siddharth Chandrasekaran <[email protected]>
Signed-off-by: Siddharth Chandrasekaran <[email protected]>
Signed-off-by: Siddharth Chandrasekaran <[email protected]>
Signed-off-by: Siddharth Chandrasekaran <[email protected]>
This looks good to me. I would recommend adding the following to
|
Good catch, thanks for the review. Will make the change and merge it. |
Okay, I thought the last line with comment "ensure CP is running for proper tear-down" was what I missed. But now I see that you are suggesting a new test. This case already covered in other tests because at the point of test module entry, CP and PD is already running and SC active. I will merge this PR as is. |
Also add tests for the added PD status.