Make sure cc and bindgen use the same size for enums #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sympatron
force-pushed
the
short-enums
branch
from
5fed41e
to
bc65ed6
Compare
Sympatron
force-pushed
the
short-enums
branch
from
bc65ed6
to
7e57976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine (Windows)
cc(usingarm-none-eabi-gcc) andbindgen(usinglibclang) did not agree on whether enums should bei32or not. This resulted in very broken code. This PR makes sure enums are always the same size forccandbindgen.Alternatively we could use
-fno-short-enums, but I would prefer-fshort-enumsbecause it will result in slightly less memory usage.