Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connReaper goroutine may leak #154

Merged
merged 3 commits into from
May 16, 2024
Merged

Fix connReaper goroutine may leak #154

merged 3 commits into from
May 16, 2024

Conversation

egorse
Copy link
Contributor

@egorse egorse commented May 14, 2024

Fix #153

sbinet
sbinet reviewed May 14, 2024
View reviewed changes
reaper/reaper_test.go Outdated Show resolved Hide resolved
reaper/reaper_test.go Outdated Show resolved Hide resolved
reaper/reaper_test.go Outdated Show resolved Hide resolved
reaper/reaper_test.go Outdated Show resolved Hide resolved
reaper/reaper_test.go Outdated Show resolved Hide resolved
reaper/reaper_test.go Outdated Show resolved Hide resolved
reaper/reaper_test.go Outdated Show resolved Hide resolved
@egorse
Rename to package leaks_test
72c908a 
Keeps leak test in separate package with proper name
@egorse egorse requested a review from sbinet May 15, 2024 11:08
sbinet
sbinet approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the minor cosmetic/doc change is applied.

thanks for the PR (and your relentless work on go-zeromq)

leaks_test/reaper_leak_test.go Outdated Show resolved Hide resolved
@sbinet sbinet merged commit fbf752e into go-zeromq:main May 16, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbinet sbinet sbinet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The connReaper goroutine may leak
2 participants
@egorse @sbinet