Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oidc provider #581

Merged
merged 8 commits into from
Jun 5, 2024

entrypoint considerations

dfae0eb
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: oidc provider #581

entrypoint considerations
dfae0eb
Select commit
Loading
Failed to load commit list.
GitHub Actions / golangci failed Jun 5, 2024 in 1s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (38)

internal/service/snapshot_test.go|138 col 25| unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
internal/service/upload_test.go|166 col 25| unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
runtime/kubernetes/mock.go|143 col 53| Error return value of (k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler is not checked (errcheck)
runtime/kubernetes/pod_tracker.go|226 col 40| Error return value of (k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler is not checked (errcheck)
runtime/kubernetes/pod_tracker_test.go|184 col 25| unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
runtime/kubernetes/image.go|32 col 30| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
runtime/kubernetes/volume.go|19 col 31| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
runtime/kubernetes/network.go|16 col 32| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
runtime/kubernetes/pod_tracker_test.go|373 col 4| expressions should not be cuddled with blocks (wsl)
executor/local/build_test.go|470 col 19| unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
executor/local/build_test.go|515 col 19| unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
internal/context/context_test.go|148 col 4| assignments should only be cuddled with other assignments (wsl)
internal/context/context_test.go|149 col 4| only one cuddle assignment allowed before if statement (wsl)
internal/context/context_test.go|132 col 4| if statements should only be cuddled with assignments (wsl)
executor/linux/build.go|709| Function 'loadLazySecrets' is too long (164 > 160) (funlen)
executor/linux/build_test.go|1928 col 19| unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
executor/linux/secret.go|209 col 37| non-wrapping format verb for fmt.Errorf. Use %w to format errors (errorlint)
executor/linux/secret.go|226 col 37| non-wrapping format verb for fmt.Errorf. Use %w to format errors (errorlint)
executor/linux/secret.go|243 col 37| non-wrapping format verb for fmt.Errorf. Use %w to format errors (errorlint)
cmd/vela-worker/start.go|57 col 4| assignments should only be cuddled with other assignments (wsl)
cmd/vela-worker/start.go|58 col 4| only one cuddle assignment allowed before if statement (wsl)
cmd/vela-worker/start.go|61 col 4| return statements should not be cuddled if block has more than two lines (wsl)
cmd/vela-worker/start.go|70 col 3| expressions should not be cuddled with declarations or returns (wsl)
cmd/vela-worker/start.go|71 col 3| if statements should only be cuddled with assignments (wsl)
cmd/vela-worker/start.go|50 col 4| assignments should only be cuddled with other assignments (wsl)
cmd/vela-worker/start.go|51 col 4| only one cuddle assignment allowed before if statement (wsl)
cmd/vela-worker/start.go|54 col 4| expressions should not be cuddled with blocks (wsl)
executor/linux/build_test.go|1224 col 4| if statements should only be cuddled with assignments (wsl)
executor/linux/build_test.go|145 col 4| defer statements should only be cuddled with expressions on same variable (wsl)
executor/linux/build_test.go|1773 col 6| only one cuddle assignment allowed before range statement (wsl)
executor/linux/build_test.go|2585 col 4| defer statements should only be cuddled with expressions on same variable (wsl)
executor/linux/build_test.go|2655 col 4| ranges should only be cuddled with assignments used in the iteration (wsl)
executor/linux/build_test.go|1214 col 4| ranges should only be cuddled with assignments used in the iteration (wsl)
executor/linux/build_test.go|2311 col 4| defer statements should only be cuddled with expressions on same variable (wsl)
executor/linux/build_test.go|207 col 6| if statements should only be cuddled with assignments used in the if statement itself (wsl)
executor/linux/build_test.go|1810 col 4| ranges should only be cuddled with assignments used in the iteration (wsl)
executor/linux/build_test.go|2428 col 6| if statements should only be cuddled with assignments used in the if statement itself (wsl)
executor/linux/build_test.go|1219 col 6| if statements should only be cuddled with assignments used in the if statement itself (wsl)

Filtered Findings (0)

Annotations

Check failure on line 138 in internal/service/snapshot_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/service/snapshot_test.go#L138

unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
internal/service/snapshot_test.go:138:25: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
		t.Run(test.name, func(t *testing.T) {
		                      ^

Check failure on line 166 in internal/service/upload_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/service/upload_test.go#L166

unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
internal/service/upload_test.go:166:25: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
		t.Run(test.name, func(t *testing.T) {
		                      ^

Check failure on line 143 in runtime/kubernetes/mock.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] runtime/kubernetes/mock.go#L143

Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
Raw output
runtime/kubernetes/mock.go:143:53: Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
	c.PodTracker.podInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
	                                                   ^

Check failure on line 226 in runtime/kubernetes/pod_tracker.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] runtime/kubernetes/pod_tracker.go#L226

Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
Raw output
runtime/kubernetes/pod_tracker.go:226:40: Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
	podInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
	                                      ^

Check failure on line 184 in runtime/kubernetes/pod_tracker_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] runtime/kubernetes/pod_tracker_test.go#L184

unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
runtime/kubernetes/pod_tracker_test.go:184:25: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
		t.Run(test.name, func(t *testing.T) {
		                      ^

Check failure on line 32 in runtime/kubernetes/image.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] runtime/kubernetes/image.go#L32

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
runtime/kubernetes/image.go:32:30: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (c *client) CreateImage(ctx context.Context, ctn *pipeline.Container) error {
                             ^

Check failure on line 19 in runtime/kubernetes/volume.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] runtime/kubernetes/volume.go#L19

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
runtime/kubernetes/volume.go:19:31: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (c *client) CreateVolume(ctx context.Context, b *pipeline.Build) error {
                              ^

Check failure on line 16 in runtime/kubernetes/network.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] runtime/kubernetes/network.go#L16

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
runtime/kubernetes/network.go:16:32: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (c *client) CreateNetwork(ctx context.Context, b *pipeline.Build) error {
                               ^

Check failure on line 373 in runtime/kubernetes/pod_tracker_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] runtime/kubernetes/pod_tracker_test.go#L373

expressions should not be cuddled with blocks (wsl)
Raw output
runtime/kubernetes/pod_tracker_test.go:373:4: expressions should not be cuddled with blocks (wsl)
			tracker.Stop()
			^

Check failure on line 470 in executor/local/build_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/local/build_test.go#L470

unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
executor/local/build_test.go:470:19: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
			planFunc: func(c *client) planFuncType {
			               ^

Check failure on line 515 in executor/local/build_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/local/build_test.go#L515

unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
executor/local/build_test.go:515:19: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
			planFunc: func(c *client) planFuncType {
			               ^

Check failure on line 148 in internal/context/context_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/context/context_test.go#L148

assignments should only be cuddled with other assignments (wsl)
Raw output
internal/context/context_test.go:148:4: assignments should only be cuddled with other assignments (wsl)
			lastLogEntry := loggerHook.LastEntry()
			^

Check failure on line 149 in internal/context/context_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/context/context_test.go#L149

only one cuddle assignment allowed before if statement (wsl)
Raw output
internal/context/context_test.go:149:4: only one cuddle assignment allowed before if statement (wsl)
			if lastLogEntry.Message != test.lastLogMessage {
			^

Check failure on line 132 in internal/context/context_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/context/context_test.go#L132

if statements should only be cuddled with assignments (wsl)
Raw output
internal/context/context_test.go:132:4: if statements should only be cuddled with assignments (wsl)
			if e := ctx.Err(); e != nil {
			^

Check failure on line 709 in executor/linux/build.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/linux/build.go#L709

Function 'loadLazySecrets' is too long (164 > 160) (funlen)
Raw output
executor/linux/build.go:709: Function 'loadLazySecrets' is too long (164 > 160) (funlen)
func loadLazySecrets(c *client, _step *pipeline.Container) error {

Check failure on line 1928 in executor/linux/build_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/linux/build_test.go#L1928

unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
executor/linux/build_test.go:1928:19: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
			planFunc: func(c *client) planFuncType {
			               ^

Check failure on line 209 in executor/linux/secret.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/linux/secret.go#L209

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
Raw output
executor/linux/secret.go:209:37: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
			return nil, fmt.Errorf("%s: %w", ErrUnableToRetrieve, err)
			                                 ^

Check failure on line 226 in executor/linux/secret.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/linux/secret.go#L226

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
Raw output
executor/linux/secret.go:226:37: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
			return nil, fmt.Errorf("%s: %w", ErrUnableToRetrieve, err)
			                                 ^

Check failure on line 243 in executor/linux/secret.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/linux/secret.go#L243

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
Raw output
executor/linux/secret.go:243:37: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
			return nil, fmt.Errorf("%s: %w", ErrUnableToRetrieve, err)
			                                 ^

Check failure on line 57 in cmd/vela-worker/start.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/start.go#L57

assignments should only be cuddled with other assignments (wsl)
Raw output
cmd/vela-worker/start.go:57:4: assignments should only be cuddled with other assignments (wsl)
			err := server.Shutdown(ctx)
			^

Check failure on line 58 in cmd/vela-worker/start.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/start.go#L58

only one cuddle assignment allowed before if statement (wsl)
Raw output
cmd/vela-worker/start.go:58:4: only one cuddle assignment allowed before if statement (wsl)
			if err != nil {
			^

Check failure on line 61 in cmd/vela-worker/start.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/start.go#L61

return statements should not be cuddled if block has more than two lines (wsl)
Raw output
cmd/vela-worker/start.go:61:4: return statements should not be cuddled if block has more than two lines (wsl)
			return gctx.Err()
			^

Check failure on line 70 in cmd/vela-worker/start.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/start.go#L70

expressions should not be cuddled with declarations or returns (wsl)
Raw output
cmd/vela-worker/start.go:70:3: expressions should not be cuddled with declarations or returns (wsl)
		logrus.Info("starting worker server")
		^

Check failure on line 71 in cmd/vela-worker/start.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/start.go#L71

if statements should only be cuddled with assignments (wsl)
Raw output
cmd/vela-worker/start.go:71:3: if statements should only be cuddled with assignments (wsl)
		if tlsCfg != nil {
		^

Check failure on line 50 in cmd/vela-worker/start.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/start.go#L50

assignments should only be cuddled with other assignments (wsl)
Raw output
cmd/vela-worker/start.go:50:4: assignments should only be cuddled with other assignments (wsl)
			err := server.Shutdown(ctx)
			^