Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update actions/setup-go action to v5 - autoclosed #545

Closed
wants to merge 1 commit into from

chore(deps): update actions/setup-go action to v5

8c2ba98
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

chore(deps): update actions/setup-go action to v5 - autoclosed #545

chore(deps): update actions/setup-go action to v5
8c2ba98
Select commit
Loading
Failed to load commit list.
GitHub Actions / golangci failed Jan 18, 2024 in 1s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (9)

runtime/kubernetes/mock.go|143 col 53| Error return value of (k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler is not checked (errcheck)
runtime/kubernetes/pod_tracker.go|227 col 40| Error return value of (k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler is not checked (errcheck)
executor/linux/build.go|496 col 1| cyclomatic complexity 32 of func (*client).ExecBuild is high (> 30) (gocyclo)
mock/docker/system.go|23 col 35| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
mock/docker/system.go|32 col 32| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
mock/docker/container.go|35 col 44| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
executor/linux/secret.go|202 col 37| non-wrapping format verb for fmt.Errorf. Use %w to format errors (errorlint)
executor/linux/secret.go|219 col 37| non-wrapping format verb for fmt.Errorf. Use %w to format errors (errorlint)
executor/linux/secret.go|236 col 37| non-wrapping format verb for fmt.Errorf. Use %w to format errors (errorlint)

Filtered Findings (0)

Annotations

Check failure on line 143 in runtime/kubernetes/mock.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] runtime/kubernetes/mock.go#L143 

Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
Raw output 
runtime/kubernetes/mock.go:143:53: Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
	c.PodTracker.podInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
	                                                   ^

Check failure on line 227 in runtime/kubernetes/pod_tracker.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] runtime/kubernetes/pod_tracker.go#L227 

Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
Raw output 
runtime/kubernetes/pod_tracker.go:227:40: Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
	podInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
	                                      ^

Check failure on line 496 in executor/linux/build.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/linux/build.go#L496 

cyclomatic complexity 32 of func `(*client).ExecBuild` is high (> 30) (gocyclo)
Raw output 
executor/linux/build.go:496:1: cyclomatic complexity 32 of func `(*client).ExecBuild` is high (> 30) (gocyclo)
func (c *client) ExecBuild(ctx context.Context) error {
^

Check failure on line 23 in mock/docker/system.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] mock/docker/system.go#L23 

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Raw output 
mock/docker/system.go:23:35: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (s *SystemService) DiskUsage(ctx context.Context, opts types.DiskUsageOptions) (types.DiskUsage, error) {
                                  ^

Check failure on line 32 in mock/docker/system.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] mock/docker/system.go#L32 

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Raw output 
mock/docker/system.go:32:32: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (s *SystemService) Events(ctx context.Context, options types.EventsOptions) (<-chan events.Message, <-chan error) {
                               ^

Check failure on line 35 in mock/docker/container.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] mock/docker/container.go#L35 

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Raw output 
mock/docker/container.go:35:44: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (c *ContainerService) ContainerAttach(ctx context.Context, ctn string, options types.ContainerAttachOptions) (types.HijackedResponse, error) {
                                           ^

Check failure on line 202 in executor/linux/secret.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/linux/secret.go#L202 

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
Raw output 
executor/linux/secret.go:202:37: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
			return nil, fmt.Errorf("%s: %w", ErrUnableToRetrieve, err)
			                                 ^

Check failure on line 219 in executor/linux/secret.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/linux/secret.go#L219 

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
Raw output 
executor/linux/secret.go:219:37: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
			return nil, fmt.Errorf("%s: %w", ErrUnableToRetrieve, err)
			                                 ^

Check failure on line 236 in executor/linux/secret.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/linux/secret.go#L236 

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
Raw output 
executor/linux/secret.go:236:37: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
			return nil, fmt.Errorf("%s: %w", ErrUnableToRetrieve, err)
			                                 ^
View more details on GitHub Actions