-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to docker v23 and add new mocked funcs #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: update info for local development * refactor: update strings to ' for consistency * chore: add secrets.env to gitignore * fix: typo in app name * docs: fix spelling mistakes * feat: add example secrets.env file * chore: reference secrets.env for ui service * refactor: update opening web ui page
#123) * fix(execute): prevent individual executor process to crash parent * switch order of err
* Add renovate.json * chore(renovate): move config to .github folder Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: David May <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
* feat: allow admin to define api protocol * fix: lint errors * fix: use TrimSuffix over Trim * fix: move comment forr clarity * fix: check that cert and key are provided * enhance: capture worker scheme, hostname, and port in one variable * fix: typo in error message * fix: move hostname check to validate.go * fix: fix error messages to beging with lower case * fix: fix error messages to beging with lower case * fix: nolint * fix: add comment to nolint to explain purpose Co-authored-by: Jordan Brockopp <[email protected]> Co-authored-by: David May <[email protected]> Co-authored-by: Jordan Brockopp <[email protected]>
* chore(deps): update module masterminds/semver to v3 * fix(deps): fix the semver upgrade * chore(deps): update module masterminds/semver to v3 Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: David May <[email protected]>
* fix: allow workers to retry registering with the server * fix: return register.go
Co-authored-by: David May <[email protected]>
* chore: linter setup and fixes, doc changes * chore: linter fixes v2
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…318) * first draft * changing dependent to continue and ditching print statements * changing continue to independent and linter work * adding new types in go mod * go mod tidy * adding additional stop check in stage loop and more comments Co-authored-by: David May <[email protected]>
Co-authored-by: dave vader <[email protected]>
* test: add kubernetes baseline for Create funcs * test: add kubernetes runtime for stages * test: prepare for test specific pod in executor test * test: add testPod helper method * test: add testPodFor(pipeline) helper method * test: mark secret containers terminated in test Pods * test: use pipeline-specific runtime instances * test: Create runtime for each executor build test * test: Adds several new test helpers. --------- Co-authored-by: JordanBrockopp <[email protected]>
…in tests (#425) * enhance: extract kubernetes runtime mock setup In order to run the PodTracker mock setup in executor tests, we need to export something * Call k8s SetupMock in executor Build test * test: Add kubernetes SetupMock to executor StreamBuild test * mark exported k8s Mock functions as test-only functions
…test (#432) * test: Fix kubernetes tests for executor AssembleBuild Adds some new WaitForPod* test helpers. * sort imports in runtime/kubernetes/kubernetes.go * test: add pause to simulate step execution * AssembleBuild test does not need to mark steps running
Co-authored-by: David May <[email protected]> Co-authored-by: Kelly Merrick <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #437 +/- ##
==========================================
- Coverage 83.42% 81.19% -2.24%
==========================================
Files 69 69
Lines 5376 5428 +52
==========================================
- Hits 4485 4407 -78
- Misses 746 872 +126
- Partials 145 149 +4
|
1 task
1 task
plyr4
force-pushed
the
chore/docker-v23
branch
from
August 11, 2023 20:00
0954e36
to
4172237
Compare
fixed by #535 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.