fix(ci): Fix silent failures in GHA reviewdog workflow

[cognifloyd]

It was installing 1.18 which can panic or have a variety of silent failures.
See: reviewdog/action-golangci-lint#249

Here is an example silent failures:

• 1.18 was installed: https://github.com/go-vela/worker/runs/6098658651?check_suite_focus=true#step:4:18
• failed: https://github.com/go-vela/worker/runs/6098658651?check_suite_focus=true#step:4:84

  /__w/_temp/reviewdog-F3Z0zl/golangci-lint-1.45.2-linux-amd64/golangci-lint run --out-format line-number --config=.golangci.yml
  level=error msg="Timeout exceeded: try increasing it by passing --timeout option"
  /__w/_temp/reviewdog-F3Z0zl/reviewdog -f=golangci-lint -name=golangci -reporter=github-pr-review -filter-mode=diff_context -fail-on-error=true -level=error

The reviewdog action always installs go, so using the container doesn't save us anything any more. So, I dropped that.

And, it was still giving me timeout errors. However, those errors do not seem to present themselves with --verbose mode. Plus, with --verbose, if it happens again, we'll have more details about what is timing out.

[codecov]

Codecov Report

Merging #319 (477e561) into master (873ae4e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #319   +/-   ##
=======================================
  Coverage   79.68%   79.68%           
=======================================
  Files          67       67           
  Lines        4962     4962           
=======================================
  Hits         3954     3954           
  Misses        862      862           
  Partials      146      146           

[jbrockopp]

LGTM

Do you plan on making this change to the other repos?

• https://github.com/go-vela/server
• https://github.com/go-vela/cli
• https://github.com/go-vela/sdk-go
• https://github.com/go-vela/types

[cognifloyd]

Do you plan on making this change to the other repos?

• https://github.com/go-vela/server
• https://github.com/go-vela/cli
• https://github.com/go-vela/sdk-go
• https://github.com/go-vela/types

Sure, I can do that. I want to let this soak for a few days to make sure it actually fixes it across a variety of PRs, and then I can create PRs for the other repos.

[cognifloyd]

Hmm. I got another timeout that didn't fail the build. It did provide more detail however:
https://github.com/go-vela/worker/runs/6138603741?check_suite_focus=true#step:3:88

  level=info msg="[config_reader] Used config file .golangci.yml"
  level=info msg="[lintersdb] Active 39 linters: [bidichk bodyclose contextcheck deadcode dupl errcheck errorlint exportloopref funlen goconst gocyclo godot gofmt goheader goimports gomoddirectives goprintffuncname gosec gosimple govet ineffassign makezero misspell nakedret nilerr noctx nolintlint revive staticcheck structcheck stylecheck tenv typecheck unconvert unparam unused varcheck whitespace wsl]"
  level=info msg="Memory: 602 samples, avg is 44.0MB, max is 44.0MB"
  level=info msg="Execution took 1m0.0024772s"
  level=info msg="[loader] Go packages loading at mode 575 (name|compiled_files|deps|exports_file|files|imports|types_sizes) took 59.998065224s"
  level=error msg="Running error: context loading failed: failed to load packages: timed out to load packages: context deadline exceeded"
  level=error msg="Timeout exceeded: try increasing it by passing --timeout option"

for comparison, here's a success
https://github.com/go-vela/worker/runs/6138156777?check_suite_focus=true#step:3:99

level=info msg="[config_reader] Used config file .golangci.yml"
  level=info msg="[lintersdb] Active 39 linters: [bidichk bodyclose contextcheck deadcode dupl errcheck errorlint exportloopref funlen goconst gocyclo godot gofmt goheader goimports gomoddirectives goprintffuncname gosec gosimple govet ineffassign makezero misspell nakedret nilerr noctx nolintlint revive staticcheck structcheck stylecheck tenv typecheck unconvert unparam unused varcheck whitespace wsl]"
  level=info msg="[loader] Go packages loading at mode 575 (compiled_files|deps|exports_file|name|files|imports|types_sizes) took 2.958085413s"
  level=info msg="[runner/filename_unadjuster] Pre-built 0 adjustments in 25.154162ms"
  level=info msg="[linters context/goanalysis] analyzers took 16.40744639s with top 10 stages: goheader: 1.723201758s, the_only_name: 1.496035296s, buildir: 1.317900872s, unconvert: 932.734843ms, dupl: 801.118034ms, goimports: 691.825862ms, gosec: 683.622952ms, buildssa: 641.508346ms, gofmt: 590.7755[89](https://github.com/go-vela/worker/runs/6138156777?check_suite_focus=true#step:3:89)ms, directives: 443.251764ms"
  level=info msg="[runner] Issues before processing: 423, after processing: 0"
  level=info msg="[runner] Processors filtering stat (out/in): nolint: 0/158, autogenerated_exclude: 341/423, exclude-rules: 158/341, filename_unadjuster: 423/423, path_prettifier: 423/423, skip_files: 423/423, cgo: 423/423, exclude: 341/341, skip_dirs: 423/423, identifier_marker: 341/341"
  level=info msg="[runner] processing took 36.300[91](https://github.com/go-vela/worker/runs/6138156777?check_suite_focus=true#step:3:91)2ms with stages: nolint: 13.675368ms, exclude-rules: 10.98[93](https://github.com/go-vela/worker/runs/6138156777?check_suite_focus=true#step:3:93)16ms, identifier_marker: 7.712851ms, autogenerated_exclude: 1.863937ms, path_prettifier: 1.604932ms, skip_dirs: 368.607µs, cgo: 51.201µs, filename_unadjuster: 29.4µs, max_same_issues: 1.2µs, uniq_by_line: 600ns, exclude: 600ns, max_from_linter: 500ns, path_shortener: 400ns, diff: 400ns, max_per_file_from_linter: 300ns, severity-rules: 300ns, skip_files: 300ns, source_code: 300ns, path_prefixer: 200ns, sort_results: 200ns"
  level=info msg="[runner] linters took 2.987110063s with stages: goanalysis_metalinter: 2.[95](https://github.com/go-vela/worker/runs/6138156777?check_suite_focus=true#step:3:95)0683649s"
  level=info msg="File cache stats: 89 entries of total size 383.1KiB"
  level=info msg="Memory: 61 samples, avg is 131.9MB, max is 340.0MB"
  level=info msg="Execution took 5.[97](https://github.com/go-vela/worker/runs/6138156777?check_suite_focus=true#step:3:97)8173183s"

So, adding a timeout doesn't make sense (59 seconds vs 6 seconds is very different!), but I'm not sure what is failing.
Looks like we at least need something that checks for that timeout message to fail the build so we can retry or rerun or something.