fix: escape newline secrets before injection (#537)

go-vela · Nov 8, 2023 · 12defde · 12defde
1 parent e728c12
commit 12defde
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/executor/linux/build.go b/executor/linux/build.go
@@ -590,6 +590,9 @@ func (c *client) ExecBuild(ctx context.Context) error {
 			}
 		}
 
+		c.Logger.Debug("escaping newlines in secrets")
+		escapeNewlineSecrets(c.Secrets)
+
 		// inject secrets for container
 		err = injectSecrets(_step, c.Secrets)
 		if err != nil {

diff --git a/executor/linux/service.go b/executor/linux/service.go
@@ -39,6 +39,9 @@ func (c *client) CreateService(ctx context.Context, ctn *pipeline.Container) err
 		return err
 	}
 
+	logger.Debug("escaping newlines in secrets")
+	escapeNewlineSecrets(c.Secrets)
+
 	logger.Debug("injecting secrets")
 	// inject secrets for container
 	err = injectSecrets(ctn, c.Secrets)