chore(release): upgrade types, server, sdk to v0.24.0-rc2 #1808

Sign in to view logs

Triggered via pull request June 14, 2024 16:21

ecrupper

opened #586

chore/release/v24-rc2

Status Success

Total duration 2m 44s

Artifacts –

reviewdog.yml

on: pull_request

Annotations

20 errors

full-review: runtime/kubernetes/mock.go#L143

Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)

full-review: runtime/kubernetes/pod_tracker.go#L226

Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)

full-review: mock/docker/image.go#L31

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)

full-review: mock/docker/image.go#L37

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)

diff-review: runtime/kubernetes/mock.go#L143

Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)

full-review: mock/docker/secret.go#L23

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)

diff-review: runtime/kubernetes/pod_tracker.go#L226

Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)

full-review: internal/service/snapshot_test.go#L138

unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)

diff-review: mock/docker/distribution.go#L19

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)

full-review: internal/service/upload_test.go#L166

unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)

diff-review: mock/docker/container.go#L35

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)

full-review: runtime/kubernetes/pod_tracker_test.go#L184

unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)

diff-review: mock/docker/volume.go#L30

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)

full-review: executor/local/build_test.go#L470

unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)

diff-review: internal/service/snapshot_test.go#L138

unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)

full-review: executor/local/build_test.go#L515

unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)

diff-review: internal/service/upload_test.go#L166

unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)

diff-review: runtime/kubernetes/pod_tracker_test.go#L184

unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)

diff-review: executor/local/build_test.go#L470

unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)

diff-review: executor/local/build_test.go#L515

unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)