Skip to content
reviewdog

chore(release): upgrade types, server, and sdk-go to v0.24.0-rc1 #1798

Sign in to view logs

chore(release): upgrade types, server, and sdk-go to v0.24.0-rc1

chore(release): upgrade types, server, and sdk-go to v0.24.0-rc1 #1798

Triggered via pull request June 5, 2024 20:15
@wsan3wsan3
opened #582
chore/release/v0.24.0-rc1
Status Success
Total duration 2m 35s
Artifacts –

reviewdog.yml

on: pull_request
diff-review
2m 24s
diff-review
full-review
2m 23s
full-review
Fit to window
Zoom out
Zoom in

Annotations

20 errors
full-review: runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
full-review: runtime/kubernetes/pod_tracker.go#L226
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
full-review: mock/docker/node.go#L22
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: mock/docker/node.go#L31
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: mock/docker/image.go#L31
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: internal/service/upload_test.go#L166
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
full-review: internal/service/snapshot_test.go#L138
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
full-review: runtime/kubernetes/pod_tracker_test.go#L184
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
full-review: executor/local/build_test.go#L470
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
full-review: executor/local/build_test.go#L515
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
diff-review: runtime/kubernetes/pod_tracker.go#L226
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
diff-review: mock/docker/distribution.go#L19
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: mock/docker/swarm.go#L22
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: mock/docker/mock.go#L58
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: internal/service/upload_test.go#L166
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: internal/service/snapshot_test.go#L138
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: runtime/kubernetes/pod_tracker_test.go#L184
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: executor/local/build_test.go#L470
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: executor/local/build_test.go#L515
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)