chore(deps): upgrade types, server, sdk to v0.23.0 #1689
reviewdog.yml
on: pull_request
diff-review
2m 14s
full-review
4m 30s
Annotations
20 errors
diff-review:
runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
diff-review:
runtime/kubernetes/pod_tracker.go#L227
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
diff-review:
mock/docker/secret.go#L23
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
diff-review:
mock/docker/container.go#L35
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
diff-review:
mock/docker/image.go#L31
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
diff-review:
internal/build/snapshot_test.go#L105
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
diff-review:
internal/build/upload_test.go#L135
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
diff-review:
internal/service/upload_test.go#L172
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
diff-review:
executor/local/build_test.go#L458
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
|
diff-review:
executor/local/build_test.go#L503
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
|
full-review:
runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
full-review:
runtime/kubernetes/pod_tracker.go#L227
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
full-review:
mock/docker/system.go#L23
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
full-review:
mock/docker/system.go#L32
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
full-review:
mock/docker/config.go#L21
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
full-review:
internal/step/snapshot_test.go#L139
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
full-review:
internal/step/snapshot_test.go#L271
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
full-review:
internal/step/upload_test.go#L172
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
full-review:
executor/local/build_test.go#L458
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
|
full-review:
executor/local/build_test.go#L503
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
|