fix(stream): add netrc password to mask targets #1909
Triggered via pull request
September 27, 2024 17:11
ecrupper
Status
Success
Total duration
2m 40s
Artifacts
–
reviewdog.yml
on: pull_request
diff-review
2m 13s
full-review
2m 27s
Annotations
20 errors
|
diff-review:
runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
|
diff-review:
runtime/kubernetes/pod_tracker.go#L226
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
|
diff-review:
cmd/vela-worker/exec.go#L31
cyclomatic complexity 31 of func `(*Worker).exec` is high (> 30) (gocyclo)
|
|
diff-review:
internal/service/upload_test.go#L166
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
internal/service/snapshot_test.go#L138
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
mock/docker/image.go#L31
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
mock/docker/image.go#L37
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
mock/docker/plugin.go#L22
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
runtime/kubernetes/pod_tracker_test.go#L184
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
executor/local/build_test.go#L470
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
|
full-review:
runtime/kubernetes/pod_tracker.go#L226
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
|
full-review:
cmd/vela-worker/exec.go#L31
cyclomatic complexity 31 of func `(*Worker).exec` is high (> 30) (gocyclo)
|
|
full-review:
mock/docker/service.go#L24
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
mock/docker/mock.go#L58
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
mock/docker/network.go#L29
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
internal/service/snapshot_test.go#L138
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
internal/service/upload_test.go#L166
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
runtime/kubernetes/pod_tracker_test.go#L184
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
executor/local/build_test.go#L470
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
|