Skip to content
reviewdog

chore: use go 1.23 and fix validate #1884

Sign in to view logs

chore: use go 1.23 and fix validate

chore: use go 1.23 and fix validate #1884

Triggered via pull request September 19, 2024 16:25
@wass3rw3rkwass3rw3rk
opened #597
chore/fix-up-go
Status Success
Total duration 2m 33s
Artifacts –

reviewdog.yml

on: pull_request
diff-review
2m 24s
diff-review
full-review
2m 17s
full-review
Fit to window
Zoom out
Zoom in

Annotations

20 errors
full-review: runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
full-review: runtime/kubernetes/pod_tracker.go#L226
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
full-review: cmd/vela-worker/exec.go#L31
cyclomatic complexity 31 of func `(*Worker).exec` is high (> 30) (gocyclo)
full-review: mock/docker/container.go#L35
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: mock/docker/swarm.go#L22
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: mock/docker/system.go#L24
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: internal/service/snapshot_test.go#L138
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
full-review: internal/service/upload_test.go#L166
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
full-review: runtime/kubernetes/pod_tracker_test.go#L184
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
full-review: executor/local/build_test.go#L470
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
diff-review: runtime/kubernetes/pod_tracker.go#L226
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
diff-review: cmd/vela-worker/exec.go#L31
cyclomatic complexity 31 of func `(*Worker).exec` is high (> 30) (gocyclo)
diff-review: mock/docker/volume.go#L30
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: mock/docker/volume.go#L72
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: mock/docker/volume.go#L109
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: internal/service/snapshot_test.go#L138
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: internal/service/upload_test.go#L166
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: runtime/kubernetes/pod_tracker_test.go#L184
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: executor/local/build_test.go#L470
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)