Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resources): get all build resources #811

Merged
merged 4 commits into from
Aug 7, 2024
Merged

fix(resources): get all build resources #811

merged 4 commits into from
Aug 7, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Aug 5, 2024 •
edited
Loading

⚠️ this is how the ui behaved prior to the elm-land rewrite.

instead, should we add pagination to the build steps tab? 🤢

@plyr4 plyr4 requested a review from a team as a code owner August 5, 2024 14:21
@plyr4 plyr4 changed the title fix: get all build steps regression fix(resources): get all build resources Aug 5, 2024
KellyMerrick
KellyMerrick previously approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

KellyMerrick
KellyMerrick approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wass3rw3rk wass3rw3rk merged commit 8284887 into main Aug 7, 2024
13 checks passed
@wass3rw3rk wass3rw3rk deleted the fix/fetch-all-steps branch August 7, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KellyMerrick KellyMerrick KellyMerrick approved these changes

@wass3rw3rk wass3rw3rk wass3rw3rk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plyr4 @KellyMerrick @wass3rw3rk