Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce excessive API calls #810

Merged
merged 22 commits into from
Aug 7, 2024
Merged

fix: reduce excessive API calls #810

merged 22 commits into from
Aug 7, 2024

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Aug 2, 2024

reduces api calls on build, services, graph, org, secrets, and repo pages

  • reduces unnecessary calls once a build is finished
  • eliminates duplicate or redundant calls
  • reverts interval on graph api requests back to 5s as was the case in 0.24. 1s graph rerenders will still be in place
  • handle 401s due to token expiration on non /token-refresh calls better

wass3r and others added 19 commits August 2, 2024 03:13
reduces api calls on build, services, graph, and repo pages
avoids calls when builds are finished
now with user agent
going to save this for a non-patch update
to make tab alerting work on errors; when this page was reduced to only
produce one call to update hooks, it didn't update tab status because
that's handled by the upper-level layout. this adopts same pattern as
source repos
this step won't update if it's not running
will redirect to last page you were on. some opportunity here to improve
messaging on login screen, or maybe sticky toast signaling reason you
are not on the page you were on before.
@wass3r wass3r marked this pull request as ready for review August 6, 2024 18:59
@wass3r wass3r requested a review from a team as a code owner August 6, 2024 18:59
KellyMerrick
KellyMerrick previously approved these changes Aug 6, 2024
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wass3rw3rk wass3rw3rk merged commit b83bba0 into main Aug 7, 2024
13 checks passed
@wass3rw3rk wass3rw3rk deleted the fix/excessive-calls branch August 7, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants