Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schedule): show schedule errors #373

Closed
wants to merge 4 commits into from
Closed

Conversation

wsan3
Copy link
Contributor

@wsan3 wsan3 commented Apr 15, 2024

Description

Whenever a user has a YAML bug in their pipeline, or any other build-breaking error that short-circuits pipeline execution, they can usually find these error in the Audit tab, where we populate the hook with the error message.

This is currently not available for schedules. Instead, the error is just logged.

Related

go-vela/community#872

@wsan3 wsan3 added the feature Indicates a new feature label Apr 15, 2024
@wsan3 wsan3 requested a review from a team as a code owner April 15, 2024 14:28
@wsan3 wsan3 changed the title feat: show schedule errors feat(schedule): show schedule errors Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (fb4a95c) to head (ef91c0a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   96.08%   96.09%           
=======================================
  Files          69       69           
  Lines        5361     5374   +13     
=======================================
+ Hits         5151     5164   +13     
  Misses        136      136           
  Partials       74       74           
Files Coverage Δ
database/schedule.go 100.00% <100.00%> (ø)
library/schedule.go 100.00% <100.00%> (ø)

@wsan3 wsan3 closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge feature Indicates a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants