-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow for step status reporting to SCM as its own context #367
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
+ Coverage 96.60% 96.61% +0.01%
==========================================
Files 69 69
Lines 5353 5375 +22
==========================================
+ Hits 5171 5193 +22
Misses 109 109
Partials 73 73
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to account for people setting report_as to the same value? i can see that happen when folks use templates in particular maybe?
Yeah I think that's a good point. Might be worth adding some validation in the compiler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ref: go-vela/community#576
Also fixes bug noted in go-vela/community#958 by setting the ground work to not report on the
pull_request
context when the action type is non-standard (opened, reopened, synchronize). Solving bugs with features!This also lays some groundwork for potential usage of the checks API whenever Vela implements GitHub App integration
Server PR, in draft form, which may be more of interest: go-vela/server#1090