Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for step status reporting to SCM as its own context #367

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Mar 21, 2024

Ref: go-vela/community#576

Also fixes bug noted in go-vela/community#958 by setting the ground work to not report on the pull_request context when the action type is non-standard (opened, reopened, synchronize). Solving bugs with features!

This also lays some groundwork for potential usage of the checks API whenever Vela implements GitHub App integration

Server PR, in draft form, which may be more of interest: go-vela/server#1090

@ecrupper ecrupper requested a review from a team as a code owner March 21, 2024 15:28
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (a7d60df) to head (cda6f93).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   96.60%   96.61%   +0.01%     
==========================================
  Files          69       69              
  Lines        5353     5375      +22     
==========================================
+ Hits         5171     5193      +22     
  Misses        109      109              
  Partials       73       73              
Files Coverage Δ
database/step.go 100.00% <100.00%> (ø)
library/step.go 100.00% <100.00%> (ø)
pipeline/container.go 80.82% <100.00%> (+0.13%) ⬆️
yaml/step.go 95.45% <100.00%> (+0.10%) ⬆️

Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to account for people setting report_as to the same value? i can see that happen when folks use templates in particular maybe?

constants/limit.go Show resolved Hide resolved
@ecrupper
Copy link
Contributor Author

do we need to account for people setting report_as to the same value? i can see that happen when folks use templates in particular maybe?

Yeah I think that's a good point. Might be worth adding some validation in the compiler.

wass3r
wass3r previously approved these changes Mar 21, 2024
@wass3r wass3r self-requested a review March 22, 2024 03:38
@wass3r wass3r dismissed their stale review March 22, 2024 03:38

doubled up

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 476edfa into main Mar 26, 2024
11 checks passed
@ecrupper ecrupper deleted the feat/step-reporting branch March 26, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants