chore(lint): address existing linter issues #1218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1218 +/- ##
=======================================
Coverage 56.87% 56.87%
=======================================
Files 599 599
Lines 32856 32869 +13
=======================================
+ Hits 18687 18695 +8
- Misses 13535 13538 +3
- Partials 634 636 +2
|
wass3rw3rk
reviewed
Oct 30, 2024
plyr4
reviewed
Oct 31, 2024
|
|
||
| globals, err := starlark.ExecFileOptions(syntax.LegacyFileOptions(), thread, "templated-base", tmpl, predeclared) |
There was a problem hiding this comment.
im assuming its not breaking, but how impactful is this change?
globals, err := starlark.ExecFileOptions(syntax.LegacyFileOptions(), thread, "templated-base", tmpl, predeclared)There was a problem hiding this comment.
It's just using what the now deprecated function has. I think we can investigate turning some of those options on, but they're all set to false right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things of note:
dupl. This rule was really only pointing out false positives. I suppose you could argue there could be some convoluted abstraction to make step and service not copy so much code, but I don't think that would be worth it. It's really just noise right now.int32for DB types does not play well withint.intwill expand based on system, so converting it toint32does not make much sense, especially when we are usingINTEGERfor the DB table declaration for bothint32andint64. So I just made allintconvert toint64for the DB.contextcheckwas pretty particular about usingdatabase.FromContext(c)from inside helper functions, so I just grabbed the interface and passed that along instead.uint64for Starlark exec limit cannot be translated to a sql type, so I moved the conversion for that to right before we pass it along to Starlark.golang-ci lint ✅ 🤞