Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sender rule for pipelines #1206

Merged
merged 7 commits into from
Oct 25, 2024
Merged

feat: add sender rule for pipelines #1206

merged 7 commits into from
Oct 25, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Oct 11, 2024

This will allow teams to specify a sender for a specific step:

- name: no robots please
   image: alpine
   ruleset:
     unless:
       sender: "Mr. Robot"
   commands:
     - run something

@ecrupper ecrupper requested a review from a team as a code owner October 11, 2024 19:18
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.87%. Comparing base (a2b0d91) to head (90693cf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
compiler/types/pipeline/ruleset.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
+ Coverage   56.85%   56.87%   +0.01%     
==========================================
  Files         599      599              
  Lines       32834    32856      +22     
==========================================
+ Hits        18668    18687      +19     
- Misses      13533    13535       +2     
- Partials      633      634       +1     
Files with missing lines Coverage Δ
api/pipeline/compile.go 62.19% <100.00%> (+6.48%) ⬆️
compiler/native/compile.go 70.37% <100.00%> (+0.07%) ⬆️
compiler/types/yaml/ruleset.go 100.00% <100.00%> (ø)
compiler/types/pipeline/ruleset.go 76.76% <57.14%> (-1.35%) ⬇️

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 237ac81 into main Oct 25, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the feat/sender-rule branch October 25, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants