Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): add instance only when metadata is not nil #1201

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Oct 3, 2024

Giving metadata default empty values when nil causes this environment section to set values it shouldn't set, resulting in the worker not supplying its own defaults. This causes local exec to not properly mount the workspace.

@ecrupper ecrupper requested a review from a team as a code owner October 3, 2024 21:38
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.79%. Comparing base (79667fd) to head (2e5f9ef).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1201   +/-   ##
=======================================
  Coverage   53.78%   53.79%           
=======================================
  Files         561      561           
  Lines       19950    19949    -1     
=======================================
+ Hits        10730    10731    +1     
+ Misses       8646     8645    -1     
+ Partials      574      573    -1     
Files with missing lines Coverage Δ
compiler/native/compile.go 71.83% <100.00%> (+0.60%) ⬆️

@ecrupper ecrupper merged commit 248b3a3 into main Oct 4, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the fix/compiler-metadata-check branch October 4, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants