Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(deployment): use server API types for deployment #1197

Merged
merged 5 commits into from
Oct 2, 2024

Merge branch 'main' into refactor/nested-api/deployment

b27bae7
Select commit
Loading
Failed to load commit list.
Merged

refactor(deployment): use server API types for deployment #1197

Merge branch 'main' into refactor/nested-api/deployment
b27bae7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 2, 2024 in 1s

53.78% (target 90.00%)

View this Pull Request on Codecov

53.78% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 88.85246% with 34 lines in your changes missing coverage. Please review.

Project coverage is 53.78%. Comparing base (23e4c60) to head (b27bae7).

Files with missing lines Patch % Lines
scm/github/deployment.go 22.22% 7 Missing ⚠️
api/types/deployment.go 96.26% 5 Missing ⚠️
database/deployment/opts.go 0.00% 4 Missing ⚠️
database/types/deployment.go 95.00% 3 Missing and 1 partial ⚠️
mock/server/deployment.go 0.00% 4 Missing ⚠️
api/webhook/post.go 0.00% 3 Missing ⚠️
database/types/build.go 57.14% 2 Missing and 1 partial ⚠️
api/deployment/create.go 0.00% 2 Missing ⚠️
database/deployment/get.go 81.81% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
+ Coverage   53.05%   53.78%   +0.72%     
==========================================
  Files         559      561       +2     
  Lines       19747    19950     +203     
==========================================
+ Hits        10477    10730     +253     
+ Misses       8701     8646      -55     
- Partials      569      574       +5
Files with missing lines Coverage Δ
api/types/build.go 99.11% <ø> (+7.34%) ⬆️
database/build/count_deployment.go 100.00% <100.00%> (ø)
database/deployment/create.go 84.61% <100.00%> (ø)
database/deployment/delete.go 100.00% <100.00%> (ø)
database/deployment/deployment.go 52.63% <ø> (ø)
database/deployment/get_repo.go 83.78% <100.00%> (+33.78%) ⬆️
database/deployment/list.go 82.85% <100.00%> (+36.19%) ⬆️
database/deployment/list_repo.go 86.04% <100.00%> (+28.15%) ⬆️
database/deployment/update.go 84.61% <100.00%> (ø)
database/resource.go 78.72% <100.00%> (+0.15%) ⬆️
... and 13 more
View more details on Codecov