fix(templates): prevent nil panic #1194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when referencing a template that defines a global environment, but the base pipeline doesn't,
pipeline.Environment
will benil
as its zero value. when the template is parsed and attempting to set the global environment we currently cause aassignment to entry in nil map
error. this fix initializes an empty environment.test case:
.vela.yml
:.nil-panic.yml
:workaround is to define
environment: {}
at the top level in the base pipeline.vela.yml