fix(dashboards): set name for deleted dashboard #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't have access to the actual name because it has been deleted. it would appear as an empty string if we don't set it. we cue off this name in the UIs to provide appropriate messaging.
ecrupper
approved these changes
Sep 23, 2024
wass3rw3rk
added a commit
to go-vela/ui
that referenced
this pull request
Sep 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
- Coverage 53.04% 53.04% -0.01%
==========================================
Files 559 559
Lines 19742 19743 +1
==========================================
Hits 10473 10473
- Misses 8700 8701 +1
Partials 569 569
|
plyr4
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scenario: another user adds dashboard, you add that dashboard to your list, other user decides to delete dashboard. the dashboard remains in your list but is inaccessible. we have the id, but not the name (because it has been deleted). this will set the name to "(not found)" in the response returned to the callee. we can utilize this in the UI(s) to provide appropriate messaging for users to update their dashboard list.