Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set metadata when not provided #1189

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Sep 19, 2024

not 100% in love with this solution but we need to be able to set metadata from the worker repo to solve nil panics in tests.

other solutions to consider:

  • decoupling worker tests from the compiler, its bad practice to test someone elses code anyways
  • move Metadata structs out of internal so that you can use WithMetadata in the worker tests

@plyr4 plyr4 requested a review from a team as a code owner September 19, 2024 16:44
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.04%. Comparing base (4b1893a) to head (6f3a839).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
compiler/native/compile.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
- Coverage   53.05%   53.04%   -0.01%     
==========================================
  Files         559      559              
  Lines       19740    19742       +2     
==========================================
  Hits        10473    10473              
- Misses       8699     8700       +1     
- Partials      568      569       +1     
Files with missing lines Coverage Δ
compiler/native/compile.go 71.22% <0.00%> (-0.51%) ⬇️

@plyr4 plyr4 merged commit f318118 into main Sep 20, 2024
11 of 13 checks passed
@plyr4 plyr4 deleted the fix/ruledata-instance-nil-metadata branch September 20, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants