Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy event code from repo and secret #1098

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Apr 1, 2024

Follow up from go-vela/types#362

@ecrupper ecrupper requested a review from a team as a code owner April 1, 2024 14:37
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.22%. Comparing base (c5813f6) to head (b8a017c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1098      +/-   ##
==========================================
- Coverage   63.27%   63.22%   -0.05%     
==========================================
  Files         348      348              
  Lines       10599    10585      -14     
==========================================
- Hits         6706     6692      -14     
  Misses       3407     3407              
  Partials      486      486              
Files Coverage Δ
database/repo/table.go 100.00% <ø> (ø)
database/secret/table.go 100.00% <ø> (ø)
mock/server/repo.go 0.00% <ø> (ø)
mock/server/secret.go 0.00% <ø> (ø)
secret/native/update.go 59.52% <ø> (-1.84%) ⬇️
secret/vault/update.go 92.45% <ø> (-0.28%) ⬇️
secret/vault/vault.go 93.71% <100.00%> (-0.34%) ⬇️

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit f591935 into main Apr 1, 2024
13 of 16 checks passed
@ecrupper ecrupper deleted the chore/drop-allowEvent-deadcode branch April 1, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants