Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): title validator handle no parentheses + enforce whitespace #1041

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

ecrupper
Copy link
Contributor

According to our docs, we should accept both formats:

Scope:

  • feat(scope): cool thing

No Scope:

  • feat: scope-less cool thing

@ecrupper ecrupper requested a review from a team as a code owner January 17, 2024 20:04
timhuynh94
timhuynh94 previously approved these changes Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3fc496) 67.03% compared to head (9e7530d) 67.03%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1041   +/-   ##
=======================================
  Coverage   67.03%   67.03%           
=======================================
  Files         330      330           
  Lines       14088    14088           
=======================================
  Hits         9444     9444           
  Misses       4165     4165           
  Partials      479      479           

@ecrupper ecrupper merged commit d79d3a5 into main Jan 18, 2024
12 of 13 checks passed
@ecrupper ecrupper deleted the fix/pr-title-validator branch January 18, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants