fix(api/list-org-repos): ensure active flag is boolean #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes go-vela/community#853 when GORM is given the proper type, it will use the proper query depending on which driver is in use.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
=======================================
Coverage 67.03% 67.03%
=======================================
Files 330 330
Lines 14088 14088
=======================================
Hits 9444 9444
Misses 4165 4165
Partials 479 479 |
plyr4
approved these changes
Jan 18, 2024
ecrupper
approved these changes
Jan 18, 2024
|
@ecrupper yes, maybe in form of documentation and/or PRs 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes go-vela/community#853
when GORM is given the proper type, it will use the appropriate query depending on which driver is in use.
tested in local setup with both postgres and sqlite. no functional differences.
as a side note, it's not intuitive to start up the local (or any) stack with sqlite. compilation requires CGO and when using alpine requires you to make sure you are on alpine 3.18 instead of the latest (see issue #1164 on github.com/mattn/go-sqlite3). latest gcc and musl in the newest alpine (3.19.x) apparently do not work with that library. alternatively, and probably preferably, it looks like you can pass
CGO_CFLAGS="-D_LARGEFILE64_SOURCE"in addition toCGO_ENABLED=1.