fix(compiler): validate yaml.Build post-expansion and fully validate step image #1036
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes go-vela/community#899
I think the real error in the issue is the fact that the pipeline passes validation more so than the repo counter not being updated. By not immediately validating the pipeline after unmarshaling, and rather waiting for the final expansion to validate, we don't need to specify
&& len(step.Template.Name) == 0
.This should result in an audit error rather than a build error — thus, no build.