fix: only update when necessary, fix test

go-vela · Oct 30, 2024 · ac86e63 · ac86e63
1 parent 2246b3d
commit ac86e63
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/scm/github/repo.go b/scm/github/repo.go
@@ -750,7 +750,7 @@ func (c *client) GetNetrcPassword(ctx context.Context, db database.Interface, r
 		l.Tracef("using github app installation token for %s/%s", r.GetOrg(), r.GetName())
 
 		// (optional) sync the install ID with the repo
-		if db != nil {
+		if db != nil && r.GetInstallID() != installID {
 			r.SetInstallID(installID)
 
 			_, err = db.UpdateRepo(ctx, r)

diff --git a/scm/github/testdata/hooks/installation_repositories_removed.json b/scm/github/testdata/hooks/installation_repositories_removed.json
@@ -49,6 +49,9 @@
       "suspended_at": null
     },
     "repositories_added": [
+
+    ],
+    "repositories_removed": [
       {
         "id": 1,
         "node_id": "MDEwOlJlcG9zaXRvcnkxMTg=",
@@ -63,9 +66,6 @@
         "full_name": "Codertocat/Hello-World2",
         "private": false
       }
-    ],
-    "repositories_removed": [
-
     ],
     "requester": null,
     "enterprise": {