enhance(api/webhook): update hook status to skipped when build is ski…

…pped (#993)

* enhance(api/webhook): update hook status to skipped when build is skipped

* fix tests

* use lowercase and — in skip message

api/build/skip.go

@@ -13,25 +13,25 @@ import (
 func SkipEmptyBuild(p *pipeline.Build) string {
 	if len(p.Stages) == 1 {
 		if p.Stages[0].Name == "init" {
-			return "skipping build since only init stage found"
+			return "skipping build since only init stage found — it is likely no rulesets matched for the webhook payload"
 		}
 	}
 
 	if len(p.Stages) == 2 {
 		if p.Stages[0].Name == "init" && p.Stages[1].Name == "clone" {
-			return "skipping build since only init and clone stages found"
+			return "skipping build since only init and clone stages found — it is likely no rulesets matched for the webhook payload"
 		}
 	}
 
 	if len(p.Steps) == 1 {
 		if p.Steps[0].Name == "init" {
-			return "skipping build since only init step found"
+			return "skipping build since only init step found — it is likely no rulesets matched for the webhook payload"
 		}
 	}
 
 	if len(p.Steps) == 2 {
 		if p.Steps[0].Name == "init" && p.Steps[1].Name == "clone" {
-			return "skipping build since only init and clone steps found"
+			return "skipping build since only init and clone steps found — it is likely no rulesets matched for the webhook payload"
 		}
 	}
 

api/build/skip_test.go

@@ -22,15 +22,15 @@ func Test_SkipEmptyBuild(t *testing.T) {
 			{
 				Name: "init",
 			},
-		}}}, "skipping build since only init stage found"},
+		}}}, "skipping build since only init stage found — it is likely no rulesets matched for the webhook payload"},
 		{"init and clone stages", args{p: &pipeline.Build{Stages: []*pipeline.Stage{
 			{
 				Name: "init",
 			},
 			{
 				Name: "clone",
 			},
-		}}}, "skipping build since only init and clone stages found"},
+		}}}, "skipping build since only init and clone stages found — it is likely no rulesets matched for the webhook payload"},
 		{"three stages", args{p: &pipeline.Build{Stages: []*pipeline.Stage{
 			{
 				Name: "init",
@@ -46,15 +46,15 @@ func Test_SkipEmptyBuild(t *testing.T) {
 			{
 				Name: "init",
 			},
-		}}}, "skipping build since only init step found"},
+		}}}, "skipping build since only init step found — it is likely no rulesets matched for the webhook payload"},
 		{"init and clone steps", args{p: &pipeline.Build{Steps: []*pipeline.Container{
 			{
 				Name: "init",
 			},
 			{
 				Name: "clone",
 			},
-		}}}, "skipping build since only init and clone steps found"},
+		}}}, "skipping build since only init and clone steps found — it is likely no rulesets matched for the webhook payload"},
 		{"three steps", args{p: &pipeline.Build{Steps: []*pipeline.Container{
 			{
 				Name: "init",

api/webhook/post.go

@@ -532,6 +532,10 @@ func PostWebhook(c *gin.Context) {
 			// set build to successful status
 			b.SetStatus(constants.StatusSkipped)
 
+			// set hook status and message
+			h.SetStatus(constants.StatusSkipped)
+			h.SetError(skip)
+
 			// send API call to set the status on the commit
 			err = scm.FromContext(c).Status(ctx, u, b, repo.GetOrg(), repo.GetName())
 			if err != nil {