refactor: remove types dependency #6385
reviewdog.yml
on: pull_request
diff-review
2m 19s
full-review
2m 45s
Annotations
20 errors
diff-review:
api/types/build.go#L60
string `...` has 3 occurrences, make it a constant (goconst)
|
diff-review:
mock/server/authentication.go#L82
string `error` has 4 occurrences, make it a constant (goconst)
|
diff-review:
compiler/types/pipeline/ruleset.go#L134
cyclomatic complexity 31 of func `(*Rules).Match` is high (> 30) (gocyclo)
|
diff-review:
database/types/build.go#L384
G115: integer overflow conversion int -> int32 (gosec)
|
diff-review:
database/types/build.go#L385
G115: integer overflow conversion int -> int32 (gosec)
|
diff-review:
database/types/repo.go#L336
G115: integer overflow conversion int -> int32 (gosec)
|
diff-review:
database/types/settings.go#L134
G115: integer overflow conversion int64 -> uint64 (gosec)
|
diff-review:
database/types/settings.go#L205
G115: integer overflow conversion uint64 -> int64 (gosec)
|
diff-review:
secret/vault/get.go#L18
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
diff-review:
secret/vault/count.go#L17
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
full-review:
api/types/build.go#L60
string `...` has 3 occurrences, make it a constant (goconst)
|
full-review:
mock/server/authentication.go#L82
string `error` has 4 occurrences, make it a constant (goconst)
|
full-review:
compiler/types/pipeline/ruleset.go#L134
cyclomatic complexity 31 of func `(*Rules).Match` is high (> 30) (gocyclo)
|
full-review:
database/types/build.go#L384
G115: integer overflow conversion int -> int32 (gosec)
|
full-review:
database/types/build.go#L385
G115: integer overflow conversion int -> int32 (gosec)
|
full-review:
database/types/repo.go#L336
G115: integer overflow conversion int -> int32 (gosec)
|
full-review:
database/types/settings.go#L134
G115: integer overflow conversion int64 -> uint64 (gosec)
|
full-review:
database/types/settings.go#L205
G115: integer overflow conversion uint64 -> int64 (gosec)
|
full-review:
secret/vault/refresh_test.go#L45
unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
|
full-review:
secret/vault/refresh_test.go#L71
unused-parameter: parameter 'in' seems to be unused, consider removing or renaming it as _ (revive)
|