fix(pipeline): include starlark exec limit to compiler flags in exec …

…+ validate (#504)
go-vela · Nov 29, 2023 · c20a385 · c20a385
1 parent d87ae80
commit c20a385
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/command/pipeline/exec.go b/command/pipeline/exec.go
@@ -161,6 +161,13 @@ var CommandExec = &cli.Command{
 			Usage:   "set the maximum depth for nested templates",
 			Value:   3,
 		},
+		&cli.Uint64Flag{
+			EnvVars: []string{"VELA_COMPILER_STARLARK_EXEC_LIMIT", "COMPILER_STARLARK_EXEC_LIMIT"},
+			Name:    "compiler-starlark-exec-limit",
+			Aliases: []string{"starlark-exec-limit", "sel"},
+			Usage:   "set the starlark execution step limit for compiling starlark pipelines",
+			Value:   7500,
+		},
 
 		// Environment Flags
 		&cli.BoolFlag{
@@ -299,6 +306,9 @@ func exec(c *cli.Context) error {
 		return err
 	}
 
+	// set starlark exec limit
+	client.StarlarkExecLimit = c.Uint64("compiler-starlark-exec-limit")
+
 	// set when user is sourcing templates from local machine
 	if len(p.TemplateFiles) != 0 {
 		client.WithLocalTemplates(p.TemplateFiles)

diff --git a/command/pipeline/validate.go b/command/pipeline/validate.go
@@ -86,6 +86,13 @@ var CommandValidate = &cli.Command{
 			Usage:   "set the maximum depth for nested templates",
 			Value:   3,
 		},
+		&cli.Uint64Flag{
+			EnvVars: []string{"VELA_COMPILER_STARLARK_EXEC_LIMIT", "COMPILER_STARLARK_EXEC_LIMIT"},
+			Name:    "compiler-starlark-exec-limit",
+			Aliases: []string{"starlark-exec-limit", "sel"},
+			Usage:   "set the starlark execution step limit for compiling starlark pipelines",
+			Value:   7500,
+		},
 		&cli.BoolFlag{
 			EnvVars: []string{"VELA_REMOTE", "PIPELINE_REMOTE"},
 			Name:    "remote",
@@ -191,6 +198,9 @@ func validate(c *cli.Context) error {
 		return err
 	}
 
+	// set starlark exec limit
+	client.StarlarkExecLimit = c.Uint64("compiler-starlark-exec-limit")
+
 	// set when user is sourcing templates from local machine
 	if len(p.TemplateFiles) != 0 {
 		client.WithLocal(true)

diff --git a/command/pipeline/validate_test.go b/command/pipeline/validate_test.go
@@ -30,6 +30,7 @@ func TestPipeline_Validate(t *testing.T) {
 	fullSet.String("repo", "octocat", "doc")
 	fullSet.String("output", "json", "doc")
 	fullSet.String("pipeline-type", "yaml", "doc")
+	fullSet.Uint64("compiler-starlark-exec-limit", 10000, "doc")
 	fullSet.Bool("remote", true, "doc")
 
 	// setup flags