Skip to content

Commit

Permalink
address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
KellyMerrick committed Jan 7, 2025
1 parent 7d8f639 commit 1bfd7ab
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion action/pipeline/exec.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func (c *Config) Exec(client compiler.Engine) error {
}

// create a slice for steps to be removed
stepsToRemove := c.Steps
stepsToRemove := c.SkipSteps

// print steps to be removed to the user
if len(stepsToRemove) > 0 {
Expand All @@ -137,6 +137,8 @@ func (c *Config) Exec(client compiler.Engine) error {
for _, step := range stage.Steps {
// if c.steps contains step.Name
if !slices.Contains(stepsToRemove, step.Name) {
fmt.Println("skip step: ", stepsToRemove)

filteredStageSteps = append(filteredStageSteps, step)
totalSteps++
}
Expand All @@ -155,6 +157,8 @@ func (c *Config) Exec(client compiler.Engine) error {

for _, step := range _pipeline.Steps {
if !slices.Contains(stepsToRemove, step.Name) {
fmt.Println("skip step: ", stepsToRemove)

filteredSteps = append(filteredSteps, step)
}
}
Expand Down
2 changes: 1 addition & 1 deletion action/pipeline/pipeline.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type Config struct {
Target string
Org string
Repo string
Steps []string
SkipSteps []string
Ref string
File string
FileChangeset []string
Expand Down
2 changes: 1 addition & 1 deletion command/pipeline/exec.go
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ func exec(c *cli.Context) error {
Target: c.String("target"),
Org: c.String(internal.FlagOrg),
Repo: c.String(internal.FlagRepo),
Steps: c.StringSlice("skip-step"),
SkipSteps: c.StringSlice("skip-step"),
File: c.String("file"),
FileChangeset: c.StringSlice("file-changeset"),
TemplateFiles: c.StringSlice("template-file"),
Expand Down

0 comments on commit 1bfd7ab

Please sign in to comment.