-
-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new .taskrc.yml to enable experiments #1982
Open
vmaerten
wants to merge
15
commits into
main
Choose a base branch
from
feat/add-yaml-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+238
−53
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9ade664
feat: add a new .task-experiments.yml to enable experiments
vmaerten 30eac21
add docs
vmaerten 99e9be1
fix lint
vmaerten b51c856
fix lint
vmaerten 403262a
better doc
vmaerten 5acdb5c
support multiple filename
vmaerten c9d9320
update docs and add json schema
vmaerten cd40eeb
un export type
vmaerten 9906374
convert to int
vmaerten 0778363
rebase
vmaerten 72dd006
convert to int
vmaerten bfbf170
lint
vmaerten 451c0f5
feat: add version to the schema
vmaerten b83bc6f
add version to the struct
vmaerten 539a18d
remove version in schema
vmaerten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
package slicesext | ||
|
||
import ( | ||
"math" | ||
"strconv" | ||
"testing" | ||
) | ||
|
||
func TestConvertIntToString(t *testing.T) { | ||
t.Parallel() | ||
input := []int{1, 2, 3, 4, 5} | ||
expected := []string{"1", "2", "3", "4", "5"} | ||
result := Convert(input, strconv.Itoa) | ||
|
||
if len(result) != len(expected) { | ||
t.Errorf("Expected length %d, got %d", len(expected), len(result)) | ||
} | ||
|
||
for i := range expected { | ||
if result[i] != expected[i] { | ||
t.Errorf("At index %d: expected %v, got %v", i, expected[i], result[i]) | ||
} | ||
} | ||
} | ||
|
||
func TestConvertStringToInt(t *testing.T) { | ||
t.Parallel() | ||
input := []string{"1", "2", "3", "4", "5"} | ||
expected := []int{1, 2, 3, 4, 5} | ||
result := Convert(input, func(s string) int { | ||
n, _ := strconv.Atoi(s) | ||
return n | ||
}) | ||
|
||
if len(result) != len(expected) { | ||
t.Errorf("Expected length %d, got %d", len(expected), len(result)) | ||
} | ||
|
||
for i := range expected { | ||
if result[i] != expected[i] { | ||
t.Errorf("At index %d: expected %v, got %v", i, expected[i], result[i]) | ||
} | ||
} | ||
} | ||
|
||
func TestConvertFloatToInt(t *testing.T) { | ||
t.Parallel() | ||
input := []float64{1.1, 2.2, 3.7, 4.5, 5.9} | ||
expected := []int{1, 2, 4, 5, 6} | ||
result := Convert(input, func(f float64) int { | ||
return int(math.Round(f)) | ||
}) | ||
|
||
if len(result) != len(expected) { | ||
t.Errorf("Expected length %d, got %d", len(expected), len(result)) | ||
} | ||
|
||
for i := range expected { | ||
if result[i] != expected[i] { | ||
t.Errorf("At index %d: expected %v, got %v", i, expected[i], result[i]) | ||
} | ||
} | ||
} | ||
|
||
func TestConvertEmptySlice(t *testing.T) { | ||
t.Parallel() | ||
input := []int{} | ||
result := Convert(input, strconv.Itoa) | ||
|
||
if len(result) != 0 { | ||
t.Errorf("Expected empty slice, got length %d", len(result)) | ||
} | ||
} | ||
|
||
func TestConvertNilSlice(t *testing.T) { | ||
t.Parallel() | ||
var input []int | ||
result := Convert(input, strconv.Itoa) | ||
|
||
if result == nil { | ||
t.Error("Expected non-nil empty slice, got nil") | ||
} | ||
if len(result) != 0 { | ||
t.Errorf("Expected empty slice, got length %d", len(result)) | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Can we remove the newlines so that
gofumpt
sorts these?