Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): ✨ add log_order configuration option #9

Conversation

dannylongeuay
Copy link
Contributor

@dannylongeuay dannylongeuay commented Apr 25, 2024

Hoping to address the issue go-semantic-release/semantic-release#168

This simply changes how logs are "walked". Instead of doing the default DFS traversal, logs would now be traversed by committer time, which looks to be more compatible with git log .

@dannylongeuay dannylongeuay changed the title fix(*): 🐛 check commits log ordering fix(*): 🐛 get commits log ordering Apr 25, 2024
@christophwitzko
Copy link
Member

Hi @dannylongeuay, thanks for this pull request. ✨

Would it make sense to make LogOrderCommitterTime optional? Or will this always behave "as expected"?
Could you also take a look at the golangci-lint errors 🙏

Cheers, Christoph

@dannylongeuay dannylongeuay changed the title fix(*): 🐛 get commits log ordering feat(*): ✨ allow optional ordering by commit time Apr 27, 2024
@dannylongeuay
Copy link
Contributor Author

@christophwitzko good call, the user can drive this configuration now

i.e. ./semantic-release --provider git --provider-opt log_order=ctime

default now stays the same

@dannylongeuay dannylongeuay changed the title feat(*): ✨ allow optional ordering by commit time feat(*): ✨ add log_order configuration option Apr 27, 2024
@christophwitzko
Copy link
Member

@dannylongeuay amazing! thanks 🥳

@christophwitzko christophwitzko merged commit c0f6ffe into go-semantic-release:master May 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants