panic on duplicated connection

resolve #360
go-rod · Feb 28, 2021 · deea7a7 · deea7a7
1 parent 3ff3f0b
commit deea7a7
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/cdp/websocket.go b/lib/cdp/websocket.go
@@ -35,6 +35,10 @@ type WebSocket struct {
 
 // Connect to browser
 func (ws *WebSocket) Connect(ctx context.Context, wsURL string, header http.Header) error {
+	if ws.conn != nil {
+		panic("duplicated connection: " + wsURL)
+	}
+
 	ctx, cancel := context.WithCancel(ctx)
 	ws.close = cancel
 

diff --git a/lib/cdp/websocket_test.go b/lib/cdp/websocket_test.go
@@ -76,3 +76,17 @@ func (t T) newPage(ctx context.Context) (*cdp.Client, string) {
 
 	return client, sessionID
 }
+
+func (t T) DuplicatedConnectErr() {
+	l := launcher.New()
+	t.Cleanup(l.Kill)
+
+	u := l.MustLaunch()
+
+	ws := &cdp.WebSocket{}
+	t.E(ws.Connect(t.Context(), u, nil))
+
+	t.Panic(func() {
+		_ = ws.Connect(t.Context(), u, nil)
+	})
+}