Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing pointer reference for slices along with test #351

Conversation

EvanOman
Copy link
Contributor

Fixes #346

NOTE: The variadic test was failing for me before adding this test:

Click me
run cmd: [build -vm=python3 -output=/tmp/gopy-3250023487 -package-prefix  ./_examples/variadic]
go build -v ./_examples/variadic

--- Processing package: github.com/go-python/gopy/_examples/variadic ---

--- building package ---
gopy.test -test.paniconexit0 -test.timeout=10m0s
goimports -w variadic.go
go build -mod=mod -buildmode=c-shared -o variadic_go.so .
/home/evan/miniconda3/bin/python3 build.py
CGO_CFLAGS="-I/home/evan/miniconda3/include/python3.10" -fPIC -Ofast
CGO_LDFLAGS="-L/home/evan/miniconda3/lib" "-lpython3.10" -lcrypt -lpthread -ldl -lutil -lm -lm
go build -mod=mod -buildmode=c-shared -o _variadic.cpython-310-x86_64-linux-gnu.so .
running python3 test.py
FAIL
exit status 1
FAIL    github.com/go-python/gopy       123.954s

Is that test flaky for other people too?

However I did confirm that the new test I added failed before the fix and passed afterwards.

Copy link
Contributor

@richecr richecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the correction, I had this error.
I'm eagerly waiting for the release.

@rcoreilly
Copy link
Member

Giving this a try now.

@rcoreilly rcoreilly merged commit 50c71dc into go-python:master May 3, 2024
0 of 3 checks passed
@rcoreilly
Copy link
Member

looks like it works -- not sure how I missed the test before. Need to fix the CI testing here too someday. just had to run format on your slices.go file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't return a slice of slices ([][]bool)
3 participants