Add lock_wait_timeout as retryable #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgo
commented
Jan 11, 2023
Comment on lines
-24
to
-40
| // SAVE_ITEM_LOOP: | ||
| // for tryNo := 1; tryNo <= maxTries; tryNo++ { | ||
| // if err := SaveItem(item); err != nil { | ||
| // if ok, myerr := my.Error(err); ok { // MySQL error | ||
| // if myerr == my.ErrDupeKey { | ||
| // return http.StatusConflict | ||
| // } | ||
| // if my.CanRetry(myerr) { | ||
| // time.Sleep(1 * time.Second) | ||
| // continue SAVE_ITEM_LOOP // retry | ||
| // } | ||
| // } | ||
| // // Error not handled | ||
| // return http.StatusInternalServerError | ||
| // } | ||
| // break SAVE_ITEM_LOOP // success | ||
| // } |
There was a problem hiding this comment.
Sorry, this is go 1.19 go fmt related. I would manually unapply, but since most editors do this the next person will just commit this change anyway :(
daniel-nichter
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock wait timeout should be retryable.
I've added a test, which works. I had to locally add a go-mod file, but I've not committed it.
For some reason the
TestMySQLDown()test is not working for me on 8.0.31, but since it's unrelated I've ignored that for now.