Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle columnIdx out range data size #689

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bingoohuang
Copy link

  1. handle columnIdx out range data size
  2. refactor code to avoid type cast

canal/sync.go Outdated
func (c *Canal) handleRowsEvent(e *replication.BinlogEvent) error {
ev := e.Event.(*replication.RowsEvent)

func (c *Canal) handleRowsEvent(e *replication.BinlogEvent, ev *replication.RowsEvent) error {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can change the parameter to (*EventHeader, *RowsEvent), that's not duplicated

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you are right!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As your suggestion, the parameters have been updated.

@skoef
Copy link
Contributor

skoef commented Apr 2, 2022

Is there perhaps a unit test for this piece of code that can be adjusted to test the specific issue @bingoohuang ran into? To prevent future regression?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants