Updated used cron library to version 3 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Apr 14, 2020
fgrosse
added a commit
that referenced
this pull request
May 3, 2020
|
I did some final smallish cleanup via 9bf71be and merged your branch. Thanks for the contribution 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I noticed that the used cron library robfig/cron is at version 3 by now whereas the current version of the module uses a much older version. Version 3 of this library aligns more with the standard notion of defining cron schedules, i.e. omits seconds.
For downwards-compatibility, I added a default schedule parser that accepts standard cron schedules with optional seconds. A future PR could contain changes to the functions in a form that they accept options so that the caller can explicity state the format of their cron schedule.