Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output mutant statuses filter #226

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Conversation

rusinikita
Copy link
Contributor

@rusinikita rusinikita commented Feb 4, 2024

Proposed changes

I want to see only useful findings. But:

  • Big projects leads to large number of printed mutants. A lot of them is KILLED
  • Using --diff flag leads to SKIPPED is 90% of output

See docs change for flag design details.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes (make all)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Closes #108 issue

@pull-request-size pull-request-size bot added the s/L Size: Denotes a Pull Request that changes 100-499 lines label Feb 4, 2024
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba6851a) 88.20% compared to head (91d49ce) 88.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   88.20%   88.55%   +0.35%     
==========================================
  Files          21       22       +1     
  Lines        1433     1477      +44     
==========================================
+ Hits         1264     1308      +44     
  Misses        144      144              
  Partials       25       25              
Flag Coverage Δ
unittests 88.55% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusinikita
Copy link
Contributor Author

rusinikita commented Feb 11, 2024

Linter checks fails because of golangci-lint update. I fixed it in #228. Let's merge #228 first, then a will rebase this. Issues will be fixed

@k3rn31 k3rn31 requested a review from giose86 February 15, 2024 08:18
giose86
giose86 previously approved these changes Feb 15, 2024
Copy link
Collaborator

@giose86 giose86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rusinikita Hi! Just fix the check that is failing, the rest is fine :)

@k3rn31 k3rn31 merged commit e7bdf6a into go-gremlins:main Feb 15, 2024
14 checks passed
@rusinikita rusinikita deleted the output-filter branch February 15, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s/L Size: Denotes a Pull Request that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a flag to hide NOT COVERED/NOT VIABLE
3 participants