mutator: fix resource leakage (#123)

There was a resource leakage since we the external management of timeout. Gremlins killed the test process, but not the child processes that remained hanging forever.
go-gremlins · Aug 12, 2022 · bc44989 · bc44989
1 parent 8df0e90
commit bc44989
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pkg/mutator/mutator.go b/pkg/mutator/mutator.go
@@ -298,6 +298,7 @@ func (mu *Mutator) getTestArgs() []string {
 	if mu.buildTags != "" {
 		args = append(args, "-tags", mu.buildTags)
 	}
+	args = append(args, "-timeout", (1*time.Second + mu.testExecutionTime).String())
 	args = append(args, "./...")
 
 	return args

diff --git a/pkg/mutator/mutator_test.go b/pkg/mutator/mutator_test.go
@@ -372,7 +372,7 @@ func TestMutatorRun(t *testing.T) {
 
 	_ = mut.Run(context.Background())
 
-	want := "go test -tags tag1 tag2 ./..."
+	want := "go test -tags tag1 tag2 -timeout 21s ./..."
 	got := fmt.Sprintf("go %v", strings.Join(holder.args, " "))
 
 	if !cmp.Equal(got, want) {