-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter support to prometheus for /api/v1/labels /api/v1/{label}/values #270
base: master
Are you sure you want to change the base?
Conversation
This reverts commit a338baf.
I can't have meny expririece with Prometheus, but looks good. |
Hi, will fix the conflict + will look into writing tests when I have time. maybe this or next week. |
Hi, it's good news. Also merge with current muster for work test (one of clickhouse version is broken and integrations tests failed). |
So, but now. Will look into this in the coming 2 weeks. Also will merge master into it again. |
…ometheus-label-filters # Conflicts: # prometheus/querier.go
Will have to check how the feature flags added in #266 interact with prometheus. |
This reverts commit eaadde6.
Not sure if my implementation is really ideal. Atm the querier.go of prometheus does not supprt filter support for metric and label searches. please review if what I do is really ok :)
This pull request implements the following changes:
If no matchers are provided graphite-clickhouse should work exactly like before.
If a matcher is provided it is matched against the Tags column.
In our case we use the stack with multi tenant support. So a proxy before graphite-clickhouse performs authentication and injects a label into all requests. {x=y}.
This change ensures that LabelNames() and LabelValues() only returns results which match {x=y}