Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring configuration #91

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Refactoring configuration #91

wants to merge 5 commits into from

Conversation

Felixoid
Copy link
Collaborator

@Felixoid Felixoid commented Jul 1, 2021

  1. The SQL queries listed here are pretty much outdated because they don't suggest using any codecs which should be the default: I'm not aware of any major downsides of using codecs. For example, why not make the schema mentioned here the default?
  2. There are no recommendations on when a user doesn't need the daily index and in what cases it can be beneficial.
  3. There is no hint as to what the cache (cache-ttl = "12h0m0s") is used for and what problems it can create like getting stale data or not getting fresh data. Right now I can only hope that everything will work fine with that cache.
  4. There's no clear description of why a user might need the hash parameter (hash = "").
  5. There are no recommendations on when a user should use an inverted index and when not. (trees?)
  6. Not clear how the min-interval/age, max-interval/age parameters affect queries when there are other tables defined (I assume that other data tables can be defined because otherwise, I don't understand why these parameters even exist). CGH
  7. Not clear how graphite-clickhouse decides which data tables to query when there are multiple matching ones. GCH
  8. What is the context = [] parameter? GCH
  9. There's no clear guideline in the documentation on when zero-timestamp=true is a bad thing, you have to search through PRs to find the answer.
  10. Having some use-case examples with fine-tuned configurations would be great.

@Felixoid Felixoid force-pushed the config-refactoring branch 2 times, most recently from 6de4e4d to 2c4addd Compare September 29, 2021 13:41
@evdevk evdevk mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant