fix concurrent index creation #295
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jinzhu thoughts? |
|
Okay, let’s keep it as is for now. The CONCURRENTLY option seems to behave differently from other options. We can consider finding a better solution in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
This resolves issue #293. The issue was a prior PR to allow for other options blindly applied the options at the end of the SQL statement. However,
concurrentlydoes not go at the end of the SQL statement. Thus #288 broke the usage of concurrently. Used the playground pointing to this change to verify that the fix works without breaking the issue "fixed" in #288.The playground verification go-gorm/playground#779.
User Case Description
My case is simple. I want to create an index concurrently as the documents state. The documents clearly state that concurrently is an OPTION. https://gorm.io/docs/indexes.html.