Skip to content

Fix: skip paths check on tag push events in workflows (#34602) #34670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 9, 2025

Backport #34602

Summary

Fix skipping of paths condition in workflows triggered by tag push events.

Details

  • Ensure workflows triggered by tag pushes bypass the paths filter check.
  • Prevent incorrect skipping of workflows due to paths conditions on tag pushes.
  • Added and updated unit tests to verify correct behavior.

## Summary
Fix skipping of `paths` condition in workflows triggered by tag push
events.

## Details
- Ensure workflows triggered by tag pushes bypass the `paths` filter
check.
- Prevent incorrect skipping of workflows due to `paths` conditions on
tag pushes.
- Added and updated unit tests to verify correct behavior.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 9, 2025
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jun 9, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 9, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 9, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 9, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) June 9, 2025 23:45
@techknowlogick techknowlogick merged commit f10e909 into go-gitea:release/v1.24 Jun 10, 2025
26 checks passed
@lunny lunny deleted the lunny/backport_34602 branch June 10, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants