Skip to content

Migrate to urfave v3 #34510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jun 10, 2025
Merged

Migrate to urfave v3 #34510

merged 29 commits into from
Jun 10, 2025

Conversation

TheFox0x7
Copy link
Contributor

@TheFox0x7 TheFox0x7 commented May 20, 2025 •
edited
Loading

migrate cli to urfave v3

add more cli tests

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 20, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/internal modifies/dependencies labels May 20, 2025
wxiaoguang
wxiaoguang reviewed Jun 4, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Jun 4, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Jun 4, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Jun 4, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Jun 4, 2025
View reviewed changes
@wxiaoguang wxiaoguang added this to the 1.25.0 milestone Jun 8, 2025
@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Jun 8, 2025
lunny
lunny reviewed Jun 8, 2025
View reviewed changes
lunny
lunny reviewed Jun 8, 2025
View reviewed changes
lunny
lunny reviewed Jun 8, 2025
View reviewed changes
lunny
lunny reviewed Jun 8, 2025
View reviewed changes
lunny
lunny reviewed Jun 8, 2025
View reviewed changes
lunny
lunny reviewed Jun 8, 2025
View reviewed changes
lunny
lunny reviewed Jun 8, 2025
View reviewed changes
@TheFox0x7
wrap errors in cert
a8701d4 
update copyright date and remove traceline
wxiaoguang
wxiaoguang reviewed Jun 8, 2025
View reviewed changes
@wxiaoguang wxiaoguang force-pushed the migrate-to-urfave-v3 branch 2 times, most recently from 171eab9 to d4a27cb Compare June 10, 2025 02:07
@wxiaoguang
Copy link
Contributor

Made some changes by accident. Reset to your latest change by force push.

I think we need to make more changes like this, proposed a PR to your fork (or could I update this PR?)

@TheFox0x7
Merge pull request #2 from wxiaoguang/migrate-to-urfave-v3
3fcc07a 
Don't call newAuthService in init stage
@TheFox0x7
Copy link
Contributor Author

I think we need to make more changes like this, proposed a PR to your fork (or could I update this PR?)

At this stage I won't mind if you do it directly. It's more of a draft thing I guess.
I got annoyed before as I had some changes that I have not committed which I would need to merge with yours which at the time seemed like it will take me a while (it did not). Though in retrospect it's good that you did it because you accidentally stopped me from overscoping this PR into a refactor.
So thanks :)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 10, 2025
@wxiaoguang
Copy link
Contributor

At this stage I won't mind if you do it directly. It's more of a draft thing I guess.

Maybe we can utilize the GitHub's "allow maintainer to edit" checkbox. If you would like to keep the PR WIP and don't want others to edit, uncheck it. When it is ready for review and accepts edits, check it. 🤔

@wxiaoguang wxiaoguang enabled auto-merge (squash) June 10, 2025 12:11
@TheFox0x7
Copy link
Contributor Author

Maybe we can utilize the GitHub's "allow maintainer to edit" checkbox. If you would like to keep the PR WIP and don't want others to edit, uncheck it. When it is ready for review and accepts edits, check it. 🤔

That... would be smart... Noted.

@wxiaoguang wxiaoguang merged commit e9f5105 into go-gitea:main Jun 10, 2025
26 checks passed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 11, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
17d7023 
* giteaofficial/main:
  Fix pull requests API convert panic when head repository is deleted. (go-gitea#34685)
  [skip ci] Updated translations via Crowdin
  Hide href attribute of a tag if there is no target_url (go-gitea#34556)
  Fix commit message rendering and some UI problems (go-gitea#34680)
  Migrate to urfave v3 (go-gitea#34510)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/dependencies modifies/go Pull requests that update Go code modifies/internal
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@TheFox0x7 @wxiaoguang @lunny @GiteaBot